That sounds like a hostile working environment. The people doing a code review should know the language and the local standards; nit sounds like they knew neither.
-- Shmuel (Seymour J.) Metz http://mason.gmu.edu/~smetz3 עַם יִשְׂרָאֵל חַי נֵ֣צַח יִשְׂרָאֵ֔ל לֹ֥א יְשַׁקֵּ֖ר ________________________________________ From: IBM Mainframe Discussion List <IBM-MAIN@LISTSERV.UA.EDU> on behalf of Bob Bridges <00000587168ababf-dmarc-requ...@listserv.ua.edu> Sent: Friday, March 15, 2024 12:37 PM To: IBM-MAIN@LISTSERV.UA.EDU Subject: Learning one's tools To rant on a related subject, I once worked at a company that instituted code reviews; a new program would be gone over by a half-dozen coworkers to be sure it adhered to local standards. This sort of thing is always painful to the coder, and nevertheless (I admit reluctantly) can have considerable value if done right. One problem I had with it, though, is that the standards we created for ourselves admitted that there are times when exceptions should be made for special cases, and yet when those cases arose no exceptions were ever allowed; the team invariably flinched, leaned back in their seats and said "no, that's not according to our standards". One particular example always rankled: Whenever someone felt the need to use a STRING or UNSTRING command (I should have said we were COBOL developers), the team always struck it down on the grounds that STRING and UNSTRING are unusual commands and some COBOL coders would be unfamiliar with it. My contention here is that that's absolutely true, and it's the job of the COBOL coder to ~learn~ the STRING and UNSTRING statements, as tools of his profession. I never persuaded anyone to that view, though. --- Bob Bridges, robhbrid...@gmail.com, cell 336 382-7313 /* Democracy is where you can say what you think even if you don't think. */ -----Original Message----- From: IBM Mainframe Discussion List <IBM-MAIN@LISTSERV.UA.EDU> On Behalf Of Rupert Reynolds Sent: Thursday, March 14, 2024 22:22 There's nothing wrong with 'signal', of course, except that a lot of people reading the code won't be expecting it :-) ---------------------------------------------------------------------- For IBM-MAIN subscribe / signoff / archive access instructions, send email to lists...@listserv.ua.edu with the message: INFO IBM-MAIN ---------------------------------------------------------------------- For IBM-MAIN subscribe / signoff / archive access instructions, send email to lists...@listserv.ua.edu with the message: INFO IBM-MAIN
