Sun Apr 06 03:55:40 2014: Request 85336 was acted upon.
Transaction: Correspondence added by SISYPHUS
       Queue: Inline
     Subject: Fails often when tested in parallel
   Broken in: 0.53
    Severity: (no value)
       Owner: Nobody
  Requestors: a...@cpan.org, ken...@cpan.org
      Status: open
 Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=85336 >


On Fri Apr 04 14:02:09 2014, rur...@x-ray.at wrote:
> Patches for the next release attached

Thanks Reini.
These patches have been applied (by hand) .... hope I got 'em right. 
Inline-0.54_01 (which contains these patches) has now been uploaded to CPAN.
All being well, it will be re-released as Inline-0.55 in a week or so.

For the Changes and C/Changes files I generally structure it so that Changes 
lists alterations to Inline and C/Changes alterations to Inline::C. (All this 
really achieves is to make it difficult for myself - especially in those cases 
where both packages are affected by the one set of changes.)

One will find that Changes and C/Changes have not been altered in strict 
accordance with the provided patches.

The only other alteration made to the provided patches was to rewrite the 2 
occurrences of:

local $ENV{MAKEFLAGS} = $ENV{MAKEFLAGS} =~ s/(--jobserver-fds=[\d,]+)//;

as:

if($ENV{MAKEFLAGS}) {
  local $ENV{MAKEFLAGS} = $ENV{MAKEFLAGS} =~ s/(--jobserver-fds=[\d,]+)//;
}

This was done to avoid 'uninitialized' warnings on systems where 
$ENV{MAKEFLAGS} was unset.

Cheers,
Rob

Reply via email to