> -----Original Message----- > From: Intel-gfx <[email protected]> On Behalf Of Ville > Syrjala > Sent: Wednesday, October 8, 2025 11:56 PM > To: [email protected] > Cc: [email protected] > Subject: [RFC][PATCH 11/11] drm/i915/prefill: Also print out the worst case > estimates > > From: Ville Syrjälä <[email protected]> > > We don't use the worst case prefill estimates yet for anything. > Print them out alongside the actual prefill details to help conmfirm they are > at leat > getting computed somewhat sanely.
Looks Good to me. Reviewed-by: Uma Shankar <[email protected]> > Signed-off-by: Ville Syrjälä <[email protected]> > --- > drivers/gpu/drm/i915/display/skl_watermark.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/skl_watermark.c > b/drivers/gpu/drm/i915/display/skl_watermark.c > index b3e9e2a0dab3..7bfd61cb41ca 100644 > --- a/drivers/gpu/drm/i915/display/skl_watermark.c > +++ b/drivers/gpu/drm/i915/display/skl_watermark.c > @@ -2322,6 +2322,17 @@ static int skl_wm_check_vblank(struct > intel_atomic_state *state, > } > } > > + /* hack to dump the worst case as well */ > + memset(&ctx, 0, sizeof(ctx)); > + intel_prefill_init_worst(&ctx, crtc_state); > + > + level = skl_max_wm_level_for_vblank(crtc_state, &ctx); > + > + if (DISPLAY_VER(display) >= 12 && > + display->sagv.block_time_us) > + intel_prefill_vblank_too_short(&ctx, crtc_state, > + display->sagv.block_time_us); > + > return 0; > } > > -- > 2.49.1
