On Thu, 2025-11-27 at 19:49 +0200, Imre Deak wrote: > Factor out compute_min_compressed_bpp_x16() also used during mode > validation in a follow-up change. > > Signed-off-by: Imre Deak <[email protected]> > --- > drivers/gpu/drm/i915/display/intel_dp.c | 26 +++++++++++++++++------ > -- > 1 file changed, 18 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c > b/drivers/gpu/drm/i915/display/intel_dp.c > index 193d9c2079347..2a5f5f1b4b128 100644 > --- a/drivers/gpu/drm/i915/display/intel_dp.c > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > @@ -2645,6 +2645,23 @@ dsc_throughput_quirk_max_bpp_x16(const struct > intel_connector *connector, > return fxp_q4_from_int(12); > } > > +static int compute_min_compressed_bpp_x16(struct intel_connector > *connector, > + enum intel_output_format > output_format) > +{
Could be "const struct intel_connector". align_min_compressed_bpp_x16() also takes const intel_connector with that, Reviewed-by: Vinod Govindapillai <[email protected]> > + int dsc_src_min_bpp, dsc_sink_min_bpp, dsc_min_bpp; > + int min_bpp_x16; > + > + dsc_src_min_bpp = intel_dp_dsc_min_src_compressed_bpp(); > + dsc_sink_min_bpp = > intel_dp_dsc_sink_min_compressed_bpp(output_format); > + dsc_min_bpp = max(dsc_src_min_bpp, dsc_sink_min_bpp); > + > + min_bpp_x16 = fxp_q4_from_int(dsc_min_bpp); > + > + min_bpp_x16 = align_min_compressed_bpp_x16(connector, > min_bpp_x16); > + > + return min_bpp_x16; > +} > + > /* > * Calculate the output link min, max bpp values in limits based on > the pipe bpp > * range, crtc_state and dsc mode. Return true on success. > @@ -2674,18 +2691,11 @@ > intel_dp_compute_config_link_bpp_limits(struct intel_connector > *connector, > > limits->link.min_bpp_x16 = fxp_q4_from_int(limits- > >pipe.min_bpp); > } else { > - int dsc_src_min_bpp, dsc_sink_min_bpp, dsc_min_bpp; > int dsc_src_max_bpp, dsc_sink_max_bpp, dsc_max_bpp; > int throughput_max_bpp_x16; > int joiner_max_bpp; > - > - dsc_src_min_bpp = > intel_dp_dsc_min_src_compressed_bpp(); > - dsc_sink_min_bpp = > intel_dp_dsc_sink_min_compressed_bpp(crtc_state->output_format); > - dsc_min_bpp = max(dsc_src_min_bpp, > dsc_sink_min_bpp); > - limits->link.min_bpp_x16 = > fxp_q4_from_int(dsc_min_bpp); > - > limits->link.min_bpp_x16 = > - align_min_compressed_bpp_x16(connector, > limits->link.min_bpp_x16); > + compute_min_compressed_bpp_x16(connector, > crtc_state->output_format); > > dsc_src_max_bpp = > dsc_src_max_compressed_bpp(intel_dp); > joiner_max_bpp =
