On Fri, 2025-12-12 at 13:01 +0200, Imre Deak wrote: > On Fri, Dec 12, 2025 at 11:39:51AM +0200, Vinod Govindapillai wrote: > > On Thu, 2025-11-27 at 19:49 +0200, Imre Deak wrote: > > > Factor out compute_min_compressed_bpp_x16() also used during mode > > > validation in a follow-up change. > > > > > > Signed-off-by: Imre Deak <[email protected]> > > > --- > > > drivers/gpu/drm/i915/display/intel_dp.c | 26 +++++++++++++++++-- > > > ---- > > > -- > > > 1 file changed, 18 insertions(+), 8 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c > > > b/drivers/gpu/drm/i915/display/intel_dp.c > > > index 193d9c2079347..2a5f5f1b4b128 100644 > > > --- a/drivers/gpu/drm/i915/display/intel_dp.c > > > +++ b/drivers/gpu/drm/i915/display/intel_dp.c > > > @@ -2645,6 +2645,23 @@ dsc_throughput_quirk_max_bpp_x16(const > > > struct > > > intel_connector *connector, > > > return fxp_q4_from_int(12); > > > } > > > > > > +static int compute_min_compressed_bpp_x16(struct intel_connector > > > *connector, > > > + enum > > > intel_output_format output_format) > > > +{ > > > > Could be "const struct intel_connector". > > My understanding is that the connector/crtc etc. objects should not > be > passed via a const pointer vs. the connector_state/crtc_state etc. > state pointers for these objects which should be const whenever > possible.
Okay. Good to know. BR Vinod > > > align_min_compressed_bpp_x16() also takes const intel_connector > > Yes, but only to match align_max_compressed_bpp_x16() which is also > called from dsc_compute_compressed_bpp(). The latter one can pass > only a > const connector pointer to the called function. > > > with that, > > > > Reviewed-by: Vinod Govindapillai <[email protected]>
