> -----Original Message-----
> From: Nikula, Jani <[email protected]>
> Sent: Wednesday, December 17, 2025 7:36 PM
> To: Shankar, Uma <[email protected]>; [email protected];
> [email protected]
> Cc: [email protected]; Shankar, Uma <[email protected]>
> Subject: Re: [PATCH 00/19] Make Display free from i915_reg.h
>
> On Wed, 17 Dec 2025, Uma Shankar <[email protected]> wrote:
> > Move the common register definition to a header to free up display
> > files from including i915_reg.h. This will help avoid dupicate
> > definitions and includes and can serve as a common file for xe, i915
> > and display module.
>
> So I commented on a number of patches, but I think the overall impression is
> that
> we should avoid moving stuff to intel_gmd_common_regs.h if at all possible.
>
> There *may* be cases that benefit from having a file like that, but I don't
> think
> most of these cases here require it.
Thanks Jani for the feedback and review.
I will re-check and review all these again and re-send a new version.
Regards,
Uma Shankar
> BR,
> Jani.
>
> >
> > Uma Shankar (19):
> > drm/{i915, xe}: Extract common registers into a separate file
> > drm/{i915, xe}: Extract South chicken registers
> > drm/{i915, xe}: Extract display interrupt definitions
> > drm/{i915, xe}: Extract DSPCLK_GATE_D
> > drm/{i915, xe}: Extract pcode definitions
> > drm/{i915, xe}: Remove i915_reg.h from intel_display_device.c
> > drm/{i915, xe}: Remove i915_reg.h from intel_dram.c
> > drm/{i915, xe}: Removed i915_reg.h from intel_display.c
> > drm/{i915, xe}: Remove i915_reg.h from intel_overlay.c
> > drm/{i915, xe}: Remove i915_reg.h from g4x_dp.c
> > drm/{i915, xe}: Remove i915_reg.h from i9xx_wm.c
> > drm/{i915, xe}: Remove i915_reg.h from g4x_hdmi.c
> > drm/{i915, xe}: Remove i915_reg.h from intel_rom.c
> > drm/{i915, xe}: Remove i915_reg.h from intel_psr.c
> > drm/{i915, xe}: Remove i915_reg.h from intel_fifo_underrun.c
> > drm/{i915, xe}: Remove i915_reg.h from intel_display_irq.c
> > drm/{i915, xe}: Remove i915_reg.h from intel_display_power_well.c
> > drm/{i915, xe}: Remove i915_reg.h from intel_modeset_setup.c
> > drm/{i915, xe}: Removed i915_reg.h from display
> >
> > drivers/gpu/drm/i915/display/g4x_dp.c | 2 +-
> > drivers/gpu/drm/i915/display/g4x_hdmi.c | 2 +-
> > drivers/gpu/drm/i915/display/hsw_ips.c | 2 +-
> > drivers/gpu/drm/i915/display/i9xx_plane.c | 2 +-
> > drivers/gpu/drm/i915/display/i9xx_wm.c | 2 +-
> > drivers/gpu/drm/i915/display/icl_dsi.c | 2 +-
> > .../gpu/drm/i915/display/intel_backlight.c | 2 +-
> > drivers/gpu/drm/i915/display/intel_bw.c | 2 +-
> > drivers/gpu/drm/i915/display/intel_casf.c | 1 -
> > drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +-
> > drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
> > drivers/gpu/drm/i915/display/intel_display.c | 2 +-
> > .../drm/i915/display/intel_display_debugfs.c | 2 +-
> > .../drm/i915/display/intel_display_device.c | 2 +-
> > .../gpu/drm/i915/display/intel_display_irq.c | 2 +-
> > .../drm/i915/display/intel_display_power.c | 2 +-
> > .../i915/display/intel_display_power_well.c | 2 +-
> > .../gpu/drm/i915/display/intel_display_regs.h | 90 +++-
> > .../gpu/drm/i915/display/intel_display_rps.c | 2 +-
> > .../gpu/drm/i915/display/intel_display_wa.c | 2 +-
> > drivers/gpu/drm/i915/display/intel_dmc.c | 2 +-
> > drivers/gpu/drm/i915/display/intel_dram.c | 3 +-
> > drivers/gpu/drm/i915/display/intel_fdi.c | 2 +-
> > .../drm/i915/display/intel_fifo_underrun.c | 2 +-
> > drivers/gpu/drm/i915/display/intel_gmbus.c | 2 +-
> > drivers/gpu/drm/i915/display/intel_hdcp.c | 2 +-
> > .../gpu/drm/i915/display/intel_hotplug_irq.c | 2 +-
> > drivers/gpu/drm/i915/display/intel_lt_phy.c | 2 +-
> > .../drm/i915/display/intel_modeset_setup.c | 2 +-
> > drivers/gpu/drm/i915/display/intel_overlay.c | 2 +-
> > .../gpu/drm/i915/display/intel_pch_display.c | 2 +-
> > .../gpu/drm/i915/display/intel_pch_refclk.c | 2 +-
> > drivers/gpu/drm/i915/display/intel_pps.c | 2 +-
> > drivers/gpu/drm/i915/display/intel_psr.c | 2 +-
> > drivers/gpu/drm/i915/display/intel_rom.c | 4 +-
> > drivers/gpu/drm/i915/display/intel_tc.c | 2 +-
> > drivers/gpu/drm/i915/display/skl_watermark.c | 2 +-
> > drivers/gpu/drm/i915/display/vlv_dsi.c | 2 +-
> > drivers/gpu/drm/i915/i915_reg.h | 463 +-----------------
> > include/drm/intel/intel_gmd_common_regs.h | 419 ++++++++++++++++
> > 40 files changed, 534 insertions(+), 514 deletions(-) create mode
> > 100644 include/drm/intel/intel_gmd_common_regs.h
>
> --
> Jani Nikula, Intel
