The bug affects users only at the time when they try to update NVM, and only F/W versions that generate errors while nvmupdate. For example X710DA2 with 0x8000ECB7 F/W is affected, but there are probably more...
After 230f3d53a547 patch, which should only replace F/W specific error codes with Linux kernel generic, all EIO errors started to be converted into EAGAIN which leads nvmupdate to retry until it timeouts and sometimes fails after more than 20 minutes in the middle of NVM update, so NVM becomes corrupted. Remove wrong EIO to EGAIN conversion and pass all errors as is. Fixes: 230f3d53a547 ("i40e: remove i40e_status") Co-developed-by: Kelvin Kang <kelvin.k...@intel.com> Signed-off-by: Kelvin Kang <kelvin.k...@intel.com> Reviewed-by: Arkadiusz Kubalewski <arkadiusz.kubalew...@intel.com> Signed-off-by: Aleksandr Loktionov <aleksandr.loktio...@intel.com> --- reproduction: ./nvmupdate64 v2->v3 commit messege typos v1->v2 commit message update --- drivers/net/ethernet/intel/i40e/i40e_adminq.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_adminq.h b/drivers/net/ethernet/intel/i40e/i40e_adminq.h index ee86d2c..55b5bb8 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_adminq.h +++ b/drivers/net/ethernet/intel/i40e/i40e_adminq.h @@ -109,10 +109,6 @@ static inline int i40e_aq_rc_to_posix(int aq_ret, int aq_rc) -EFBIG, /* I40E_AQ_RC_EFBIG */ }; - /* aq_rc is invalid if AQ timed out */ - if (aq_ret == -EIO) - return -EAGAIN; - if (!((u32)aq_rc < (sizeof(aq_to_posix) / sizeof((aq_to_posix)[0])))) return -ERANGE; -- 2.25.1