> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-boun...@osuosl.org> On Behalf Of > Aleksandr Loktionov > Sent: Wednesday, June 12, 2024 4:04 AM > To: intel-wired-...@lists.osuosl.org; Nguyen, Anthony L > <anthony.l.ngu...@intel.com>; Loktionov, Aleksandr > <aleksandr.loktio...@intel.com> > Cc: net...@vger.kernel.org; Kang, Kelvin <kelvin.k...@intel.com>; > Kubalewski, Arkadiusz <arkadiusz.kubalew...@intel.com> > Subject: [Intel-wired-lan] [PATCH iwl-net v3] i40e: fix hot issue NVM content > is > corrupted after nvmupdate > > The bug affects users only at the time when they try to update NVM, and only > F/W versions that generate errors while nvmupdate. For example X710DA2 > with 0x8000ECB7 F/W is affected, but there are probably more... > > After 230f3d53a547 patch, which should only replace F/W specific error codes > with Linux kernel generic, all EIO errors started to be converted into EAGAIN > which leads nvmupdate to retry until it timeouts and sometimes fails after > more than 20 minutes in the middle of NVM update, so NVM becomes > corrupted. > > Remove wrong EIO to EGAIN conversion and pass all errors as is. > > Fixes: 230f3d53a547 ("i40e: remove i40e_status") > Co-developed-by: Kelvin Kang <kelvin.k...@intel.com> > Signed-off-by: Kelvin Kang <kelvin.k...@intel.com> > Reviewed-by: Arkadiusz Kubalewski <arkadiusz.kubalew...@intel.com> > Signed-off-by: Aleksandr Loktionov <aleksandr.loktio...@intel.com> > --- > reproduction: > ./nvmupdate64 > > v2->v3 commit messege typos > v1->v2 commit message update > --- > drivers/net/ethernet/intel/i40e/i40e_adminq.h | 4 ---- > 1 file changed, 4 deletions(-)
Tested-by: Tony Brelinski <tony.brelin...@intel.com>