> -----Original Message-----
> From: Nguyen, Anthony L <anthony.l.ngu...@intel.com>
> Sent: Thursday, June 13, 2024 11:27 PM
> To: Loktionov, Aleksandr <aleksandr.loktio...@intel.com>; intel-wired-
> l...@lists.osuosl.org
> Cc: net...@vger.kernel.org; Kang, Kelvin <kelvin.k...@intel.com>;
> Kubalewski, Arkadiusz <arkadiusz.kubalew...@intel.com>; Kitszel,
> Przemyslaw <przemyslaw.kits...@intel.com>
> Subject: Re: [PATCH iwl-net v3] i40e: fix hot issue NVM content is
> corrupted after nvmupdate
>
> On 6/12/2024 4:04 AM, Aleksandr Loktionov wrote:
>
> As Przemek has pointed out...
>
> "hot issue" doesn't necessarily carry the same meaning; better to just
> drop that out of the title.
>
Does it make sense to change the commit title and start a new mailing list
thread when it was already tested and ready to merge?
> > The bug affects users only at the time when they try to update NVM,
> > and only F/W versions that generate errors while nvmupdate. For
> > example X710DA2 with 0x8000ECB7 F/W is affected, but there are
> probably more...
> >
> > After 230f3d53a547 patch, which should only replace F/W specific
> error
> > codes
>
> Could you cite the commit in the preferred style of SHA +title?
Please see Fixed: tag below
>
> I'd suggest
>
> 'After commit 230f3d53a547 ("i40e: remove i40e_status"),'
>
Is it really needed to mention it twice in the commit message?
> Thanks,
> Tony
>
> > with Linux kernel generic, all EIO errors started to be converted
> into
> > EAGAIN which leads nvmupdate to retry until it timeouts and
> sometimes
> > fails after more than 20 minutes in the middle of NVM update, so NVM
> becomes corrupted.
> >
> > Remove wrong EIO to EGAIN conversion and pass all errors as is.
> >
> > Fixes: 230f3d53a547 ("i40e: remove i40e_status")
> > Co-developed-by: Kelvin Kang <kelvin.k...@intel.com>
> > Signed-off-by: Kelvin Kang <kelvin.k...@intel.com>
> > Reviewed-by: Arkadiusz Kubalewski <arkadiusz.kubalew...@intel.com>
> > Signed-off-by: Aleksandr Loktionov <aleksandr.loktio...@intel.com>
