On Fri, Jul 18, 2025 at 12:56:29PM -0700, Jacob Keller wrote:
>
>
> On 7/18/2025 9:50 AM, Simon Horman wrote:
> > On Thu, Jul 17, 2025 at 09:57:09AM -0700, Jacob Keller wrote:
> >>
> >> Fixes: 91427e6d9030 ("ice: Support 5 layer topology")
> >> Signed-off-by: Jacob Keller <[email protected]>
> >
> > Thanks for the extensive explanation.
> >
>
> Thanks. This took me forever to track down exactly what went wrong,
> enough that I had to have the customer send me the card back because we
> thought the firmware was unrecoverable and bricked.
Ouch!
...
> >> msleep(1000);
> >> ice_reset(hw, ICE_RESET_CORER);
> >> - /* CORER will clear the global lock, so no explicit call
> >> - * required for release.
> >> - */
> >> + ice_check_reset(hw);
> >>
> >> - return 0;
> >> +reinit_hw:
> >
> > nit: I think you can move this label above ice_check_reset().
> > As the only place that jumps to this label calls ice_check_reset()
> > immediately before doing so. If so, renaming the label might
> > also be appropriate (up to you on all fronts:)
> >
>
> You're right thats probably slightly better. I'm not sure its worth a
> re-roll vs getting this fix out since its a pretty minor difference.
Yes, agreed. I'm happy to let this lie if you prefer.
...
