On Fri, 12 Jun 2020 at 10:30, Jakob Givoni <ja...@givoni.dk> wrote: > > Token names shouldn't show up. Everyone is agreeing with that statement. > > Universally. Let's fix that problem rather than create new ones by not > > addressing the underlying issue. > > Are you saying that this RFC is creating a new problem? If so, please > elaborate. >
There is a small nuisance for anyone relying on the exact output of the parser messages, and a small chance of further confusion from existing users ("what's T_DOUBLE_COLON, I've never seen that before"). To emphasise: these are very small nuisances, and not a reason to decline the renaming. If we're going to change the errors anyway, we might as well hide the token names at the same time, for barely more impact. If I don't see any objection, I will tidy up my patch to do so this weekend. If that change is made in 8.0, renaming the token is, as you say, almost entirely internal. On Fri, 12 Jun 2020 at 11:04, Guilliam Xavier <guilliam.xav...@gmail.com> wrote: > Could this be discussed rather in the "Improvement to errors" thread? https://externals.io/message/110276 I will post a new thread to discuss details when I've learned more about what's actually possible with the current parser. I may be wrong, but I believe the examples given in that message would require a completely separate implementation, because they are raised at run-time by the ZPP macros, whereas the ones discussed in this thread are raised directly by the parser. In both cases, I think we know roughly what we'd like to see, so there's not much else to say until somebody looks into actually doing it. Regards, -- Rowan Tommins [IMSoP]