Cool. I hope I'll have the time to give that a shot over the holidays.
Great work, nice patch (from what I, with my rubbish knowledge, can
tell :D)
David
Am 23.12.2007 um 14:40 schrieb Christian Seiler:
Hi David!
One question about the names you generate for the function table in
combination with opcode caches. [...]
I now updated the patch so that this problem is addressed. You will
find
it here:
http://www.christian-seiler.de/temp/closures-php-5-3-v2.patch
The compiled functions are now named __compiled_lambda_$hash_$counter,
where $counter is a per-file lambda counter and $hash is a hash made
from the file name (see hash_compiled_filename in zend_compile.c, I
wasn't sure how good Zend's hash function is with duplicates so I
hashed
the file name AND its basename - feel free to change that function if
you have a better idea or know it's safe to only hash the filename
itself because duplicates are too rare).
Regards,
Christian
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
