On 03/22/2013 02:04 PM, Stas Malyshev wrote:
> Hi!
> 
>> just FYI, there's some non-portable code in Zend OpCache (alpha5 was built
>> just fine), which prevents building of php5 beta1 on non-Linux systems:
>>
>> FreeBSD: https://bugs.php.net/bug.php?id=64490
>> Hurd i386:
>> https://buildd.debian.org/status/fetch.php?pkg=php5&arch=hurd-i386&ver=5.5.0~beta1-1&stamp=1363956014
>>
>> While hurd might be not important, the general experience is that writing
>> portable code helps the general quality of the code :).
> 
> We probably need to make it self-disable on systems where we don't have
> suitable flock driver. For freebsd though it's strange since it has if
> defined(__FreeBSD__) clause there. Is there some other define that
> should be checked instead?

Yes, Joe attached a patch to bug 64490 that fixes the check.

-Rasmus

-- 
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to