On Mon, May 13, 2013 at 1:09 PM, Dmitry Stogov <dmi...@zend.com> wrote:
> Hi Nikita, > > I didn't get why do we need separate zend_std_compare() function. > May be I just didn't look careful :) > Good point, that was not really necessary. I moved the code back into compare_function. > It would be great to look into the patch between master and current of > your branch. > You can find a diff between master and my branch on the PR: https://github.com/php/php-src/pull/342/files The relevant diff for the compare handler is here: https://github.com/php/php-src/pull/342/files#L2R1581 Nikita