On Tue, Sep 23, 2014 at 4:13 PM, Ferenc Kovacs <tyr...@gmail.com> wrote: > On Tue, Sep 23, 2014 at 10:27 AM, Florian Anderiasch <m...@anderiasch.de> > wrote: > >> On 09/22/2014 08:56 PM, Zeev Suraski wrote: >> > The first bullet is the one this thread deals with so far. It clearly >> > states that having an SVN account isn't enough - but that code >> contributions >> > to PHP are mandatory. We should probably consider revising that to also >> > account for people contributing docs and other types of submissions. I'd >> > also consider adding a requirement for contributing at least X commits >> (say >> > 20 or 50) so that someone who did a one-off or two-off patch won't have >> the >> > same vote as someone who contributed hundreds or thousands of commits. >> I >> > believe this data can be easily pulled from git. >> >> That's a horrible idea. From a very quick unscientific glance at >> https://github.com/php/php-src/graphs/contributors there's only ~50 >> people *ever* to have more than 20 commits in php-src. (Incidentally I'm >> at the very bottom with 22, should I be happy to just have made the cut >> if php-src commits are the only metric?) >> > > from a quick look that list only contains the contributors with an existing > (and matching) github account. > there are around 170 accounts with 20 or more commits: > https://gist.github.com/Tyrael/3bf0d24d33cf6b9e828b > ofc. some of those accounts are technical ones like the one with the empty > name (was used for changelog entries from a quick look), and there are also > some commits which were done by the same person but using different > email/author name.
Even that list is not complete - it shows me with only 1 commit while I've got 2 pull requests merged. Cheers, Andrey. -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php
