> On Jun 15, 2015, at 9:53 AM, Dmitry Stogov <dmi...@zend.com> wrote: > > On Mon, Jun 15, 2015 at 4:55 PM, Aaron Piotrowski <aa...@icicle.io > <mailto:aa...@icicle.io>> wrote: > >> >> On Jun 15, 2015, at 6:56 AM, Anatol Belski <anatol....@belski.net >> <mailto:anatol....@belski.net>> wrote: >> >> Would you like me to move zend_ce_throwable to zend_exceptions.h/c or is >> that >> something you’d take care of after the merge? >> > > I don't care about this a lot. I just think it's better. > If you don’t see any problems, please, move the code. >
Moving the definition of zend_ce_throwable to zend_exceptions.h/c requires either: 1. Moving #define REGISTER_ITERATOR_INTERFACE from zend_interfaces.c to zend_interfaces.h so it is available in zend_exceptions.c (I could take the opportunity to rename this macro to REGISTER_INTERFACE). 2. Defining a macro in zend_exceptions.c that is identical to REGISTER_ITERATOR_INTERFACE. Which option sounds better? Aaron Piotrowski
