Hi, > -----Original Message----- > From: Dan Ackroyd [mailto:dan...@basereality.com] > Sent: Tuesday, July 18, 2017 10:42 AM > To: Christoph M. Becker <cmbecke...@gmx.de> > Cc: internals@lists.php.net > Subject: [PHP-DEV] Re: Bundled libraries upgrade 'process' > > On 17 July 2017 at 20:09, Christoph M. Becker <cmbecke...@gmx.de> wrote: > > On 17.07.2017 at 16:12, Dan Ackroyd wrote: > > > >> I just investigated an alleged bug related to the SQLite3 extension. > > > > Can you please report the bug and assign it to me. I can't promise > > that I'll be able to fix it, but I would take a look. > > > > It's already been reported and fixed upstream. > > Reported 'bug': https://bugs.php.net/bug.php?id=74883 > > Fixed in commit: https://www.sqlite.org/src/info/f27b6370407842e2 > Thanks for the info. The fix in mainstream doesn't look critical, as the return code is already being caught in PHP. Clear, there are explicit option checks in the linked patch, but the currently bundled Sqlite would bail out anyway. A possible improvement in the end is a different error text. The version jump seems to be big and barely justified, furthermore I'd be hesitant to bundle a just released version. Except there are some other bugs that are fixed by the newer version, I would rather go by applying the patch to the current bundled lib (if possible) or letting it go.
Regards Anatol
