>From the platform extension project maintainer perspective, this commit looks >reasonable action.
However, This code affects across the CA Layer and security module together. This code should have been reviewed by these two Maintainer/Sub Maintainer together. But this review has not been executed especially from security project. If they checked it could be detected. For the Jenkins setting issue, setting change usually requires consequent build failure so I delay to apply it into this week to minimize the trouble. As you may know, we are suffer from the Jenkins build waiting more than a day for one commit. Considering all aspect, I suggest to revert as my proposal below. 1. https://gerrit.iotivity.org/gerrit/#/c/11227/ revert. 2. After master merge, on top of there https://gerrit.iotivity.org/gerrit/#/c/10743/ revert. 3. After master merge, on top of there , Add Jenkins Job tcp, secure =1. 4. Undo revert https://gerrit.iotivity.org/gerrit/#/c/10743/ 5. Undo revert https://gerrit.iotivity.org/gerrit/#/c/11227/ One question, two commit has dependency? https://gerrit.iotivity.org/gerrit/#/c/10743/ https://gerrit.iotivity.org/gerrit/#/c/11227/ BR, Uze Choi From: iotivity-dev-bounces at lists.iotivity.org [mailto:[email protected]] On Behalf Of Dave Thaler via iotivity-dev Sent: Monday, September 19, 2016 8:46 PM To: jihwan.seo at samsung.com; Dave Thaler via iotivity-dev; ??? Subject: Re: [dev] Request to revert the merged patches(#11227,#10743) These functions are intended to be part of the platform support layer. I sent emails to Jon some time ago (Sep 9th) and got no response, including a notice that if I didn?t hear any objections within another week, I would assume silence means ok to take over as maintainer since the point of these is not about connectivity but rather platform abstraction. So I merged as Platform Support maintainer after more than another week passed without any objection. The changes were out for code review for nearly 3 weeks so there was plenty of opportunity for comment. Dave From: iotivity-dev-bounces at lists.iotivity.org [mailto:[email protected]] On Behalf Of ??? Sent: Monday, September 19, 2016 8:37 PM To: Dave Thaler via iotivity-dev <iotivity-dev at lists.iotivity.org>; ??? <dongik.lee at samsung.com> Subject: Re: [dev] Request to revert the merged patches(#11227,#10743) Hi Dave. I have a simple question. Why did you merge #11227, #10743? Since Jon.A.Cruz is a maintainer of Base Layer and Ashok is a sub-maintainer, I don't think, you can merge the codes without Jon's comment. I don't understand your position. I think the changes should have been merged by Jon or Ashok. Can you tell me you exact position? --------- Original Message --------- Sender : Dave Thaler via iotivity-dev <iotivity-dev at lists.iotivity.org> Date : 2016-09-19 20:24 (GMT+9) Title : Re: [dev] Request to revert the merged patches(#11227,#10743) I don?t understand. Jenkins passed with both of these, and https://build.iotivity.org/ci/view/iotivity-merge/ shows that the merge builds also pass fine. From: ??? [mailto:[email protected]] Sent: Monday, September 19, 2016 8:07 PM To: Dave Thaler <dthaler at microsoft.com> Cc: iotivity-dev at lists.iotivity.org Subject: Request to revert the merged patches(#11227,#10743) Dear Dave, After merging the below patches, the current iotivity scons build with SECURED=1 WITH_TCP=1 WITH_CLOUD=1 results in failure. build error happens with commit id fef945f09258318fc799210618c7115648df51b3 https://gerrit.iotivity.org/gerrit/#/c/11227/ https://gerrit.iotivity.org/gerrit/#/c/10743/ Compiling out/linux/x86_64/release/resource/csdk/connectivity/src/adapter_util/ca_adapter_net_tls.os resource/csdk/connectivity/src/adapter_util/ca_adapter_net_tls.c:30:21: fatal error: camutex.h: No such file or directory compilation terminated. scons: *** [out/linux/x86_64/release/resource/csdk/connectivity/src/adapter_util/ca_adapter_net_tls.os] Error 1 Basically, the above options should be successful. I am wondering why jenkins build script does not reflect for the regarding option for now. Could you revert the above patches and upload patch again after jenkins build option has been updated ? BR, Dongik _____ Dongik LEE (Principal Engineer) Security Lab.(Software R&D Center) SAMSUNG ELECTRONICS CO.,LTD Mobile : +82-10-5091-8190 E-mail : dongik.lee at samsung.com _____ _______________________________________________ iotivity-dev mailing list iotivity-dev at lists.iotivity.org https://lists.iotivity.org/mailman/listinfo/iotivity-dev <http://v70ext.samsung.net/mail/ext/v1/external/status/update?userid=jihwan.seo&do=bWFpbElEPTIwMTYwOTE5MTEzNjU5ZXBjbXMxcDI3MmUyMDFhYmYwMWVhMzkxN2MzY2ZlZDA5YmMyYjBkYyZyZWNpcGllbnRBZGRyZXNzPWlvdGl2aXR5LWRldkBsaXN0cy5pb3Rpdml0eS5vcmc_> -------------- next part -------------- HTML ?????? ??????????????... URL: <http://lists.iotivity.org/pipermail/iotivity-dev/attachments/20160919/b05e5241/attachment.html> -------------- next part -------------- A non-text attachment was scrubbed... Name: image001.gif Type: image/gif Size: 13402 bytes Desc: ?????? ?? ????????. URL: <http://lists.iotivity.org/pipermail/iotivity-dev/attachments/20160919/b05e5241/attachment.gif>
