Agreed. We can't wait indefinitely for a maintainer to review code, and we should not revert changes based on requirements which aren't being validated in Jenkins.
Who has the action item to add SECURED=1, WITH_TCP=1 and WITH_CLOUD=1 to the Jenkins build, and is this going into 1.2.0? Is there a Jira ticket tracking? Thanks! Justin -----Original Message----- From: iotivity-dev-bounces at lists.iotivity.org [mailto:[email protected]] On Behalf Of Thiago Macieira Sent: Monday, September 19, 2016 11:01 AM To: iotivity-dev at lists.iotivity.org; Dave Thaler <dthaler at microsoft.com> Subject: Re: [dev] Request to revert the merged patches(#11227,#10743) On segunda-feira, 19 de setembro de 2016 11:45:49 PDT Dave Thaler via iotivity-dev wrote: > These functions are intended to be part of the platform support layer. > I sent emails to Jon some time ago (Sep 9th) and got no response, > including a notice that if I didn?t hear any objections within another > week, I would assume silence means ok to take over as maintainer since > the point of these is not about connectivity but rather platform abstraction. > So I merged as Platform Support maintainer after more than another > week passed without any objection. The changes were out for code > review for nearly 3 weeks so there was plenty of opportunity for comment. Dave was correct in doing that. Maintainers can help each other out and pick up the slack when they don't act within reasonable time to give feedback. The Lead Maintainer can intervene if there's a dispute. -- Thiago Macieira - thiago.macieira (AT) intel.com Software Architect - Intel Open Source Technology Center _______________________________________________ iotivity-dev mailing list iotivity-dev at lists.iotivity.org https://lists.iotivity.org/mailman/listinfo/iotivity-dev
