[ 
https://issues.apache.org/jira/browse/ARTEMIS-1162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16009197#comment-16009197
 ] 

ASF GitHub Bot commented on ARTEMIS-1162:
-----------------------------------------

Github user michaelandrepearce commented on the issue:

    https://github.com/apache/activemq-artemis/pull/1268
  
    @franz1981 I hope you don't mind me doing this, just as the new timed 
buffer work you've done, whilst benchmarked we won't get any proper real use 
feedback till systems hit production, and just want to mitigate risks.
    
    Also it will make less risky other changes, such as the IOLimiter.
    
    Idea would be to add an extra timed buffer type enum, for your IOLimiter 
version also.



> Make new Adapting TimedBuffer and old Fixed TimedBuffer configurable
> --------------------------------------------------------------------
>
>                 Key: ARTEMIS-1162
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-1162
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>    Affects Versions: 2.1.0
>            Reporter: Michael Andre Pearce
>             Fix For: 2.2.0
>
>
> New Adapting TimedBuffer was added and replaced existing Fixed TimedBuffer. 
> This could cause behaviour/performance change of journal IO (and hopefully 
> for the better).
> As this hasn't been run significantly in a real world production environment, 
> to avoid causing any production deployment issues having unexpected behaviour 
> changes, or to allow managed rollout and rollback.
> We would like to add back the fixed timed buffer (default), and make it 
> configurable to the new improved timed buffer. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to