[
https://issues.apache.org/jira/browse/ARTEMIS-1162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16009207#comment-16009207
]
ASF GitHub Bot commented on ARTEMIS-1162:
-----------------------------------------
Github user franz1981 commented on the issue:
https://github.com/apache/activemq-artemis/pull/1268
@michaelandrepearce And about loosing some tests, it is not a big deal; the
deleted ones has some issues, so it has no practical effect to have them
deleted.
On
https://github.com/franz1981/activemq-artemis/tree/timed_buffer_iops_test the
[shouldNotFlusgUntilTimeout
test](https://github.com/franz1981/activemq-artemis/blob/12c34475f16a73d669c3307999e6fa03601c6cb3/tests/unit-tests/src/test/java/org/apache/activemq/artemis/tests/unit/core/journal/impl/TimedBufferTest.java#L137-L137)
shows that with the original implementation was possible to go out of IOPS too.
> Make new Adapting TimedBuffer and old Fixed TimedBuffer configurable
> --------------------------------------------------------------------
>
> Key: ARTEMIS-1162
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1162
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.1.0
> Reporter: Michael Andre Pearce
> Fix For: 2.2.0
>
>
> New Adapting TimedBuffer was added and replaced existing Fixed TimedBuffer.
> This could cause behaviour/performance change of journal IO (and hopefully
> for the better).
> As this hasn't been run significantly in a real world production environment,
> to avoid causing any production deployment issues having unexpected behaviour
> changes, or to allow managed rollout and rollback.
> We would like to add back the fixed timed buffer (default), and make it
> configurable to the new improved timed buffer.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
