[
https://issues.apache.org/jira/browse/ARTEMIS-1162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16009210#comment-16009210
]
ASF GitHub Bot commented on ARTEMIS-1162:
-----------------------------------------
Github user michaelandrepearce commented on the issue:
https://github.com/apache/activemq-artemis/pull/1268
I actually started with a boolean flag option, but then thought about the
other bits being added and before we know it we'd have quite a few flags which
equate to lots of config options to be added in broker.xml
Where as having an enum from a user perspective means you simply define
which timed buffer type you want, and is a little more plain English with what
you're selecting.
Maybe I can see if I can make the enum for config so we don't explode the
config paeans but re work the reintroduction of the old behaviour like you
propose.
> Make new Adapting TimedBuffer and old Fixed TimedBuffer configurable
> --------------------------------------------------------------------
>
> Key: ARTEMIS-1162
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1162
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.1.0
> Reporter: Michael Andre Pearce
> Fix For: 2.2.0
>
>
> New Adapting TimedBuffer was added and replaced existing Fixed TimedBuffer.
> This could cause behaviour/performance change of journal IO (and hopefully
> for the better).
> As this hasn't been run significantly in a real world production environment,
> to avoid causing any production deployment issues having unexpected behaviour
> changes, or to allow managed rollout and rollback.
> We would like to add back the fixed timed buffer (default), and make it
> configurable to the new improved timed buffer.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
