[
https://issues.apache.org/jira/browse/ARTEMIS-2320?focusedWorklogId=234342&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-234342
]
ASF GitHub Bot logged work on ARTEMIS-2320:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/Apr/19 07:23
Start Date: 29/Apr/19 07:23
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #2652:
ARTEMIS-2320 Assorted small code fixes, mostly from IntelliJ autofixes
URL: https://github.com/apache/activemq-artemis/pull/2652#discussion_r279256136
##########
File path:
tests/jms-tests/src/test/java/org/apache/activemq/artemis/jms/tests/tools/container/InVMInitialContextFactory.java
##########
@@ -104,10 +100,6 @@ public Context getInitialContext(final Hashtable<?, ?>
environment) throws Namin
}
}
- public static void reset() {
- InVMInitialContextFactory.initialContexts = new HashMap<>();
Review comment:
As long as no ones using this in extended tests then fair enough. Concern is
just where people may use and extend it in their own projects. If maybe cross
check with wildfly project (known big user) to make sure. Then im happy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 234342)
Time Spent: 4h (was: 3h 50m)
> Upgrade errorprone compiler dependency to 2.3.3 and review the new warnings
> ---------------------------------------------------------------------------
>
> Key: ARTEMIS-2320
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2320
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.7.0
> Reporter: Jiri Daněk
> Priority: Minor
> Time Spent: 4h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
