[
https://issues.apache.org/jira/browse/ARTEMIS-2320?focusedWorklogId=234533&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-234533
]
ASF GitHub Bot logged work on ARTEMIS-2320:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/Apr/19 14:07
Start Date: 29/Apr/19 14:07
Worklog Time Spent: 10m
Work Description: jdanekrh commented on issue #2651: ARTEMIS-2320 Fix
ClassCanBeStatic errorprone warning
URL: https://github.com/apache/activemq-artemis/pull/2651#issuecomment-487593830
I'm not going to pull out any static nested classes into their own files. If
this should get done, somebody more familiar with the codebase needs to do it.
Possibly in a subsequent PR.
I was thinking, we could configure the ClassCanBeStatic warning to be an
error. Then all subsequently created nested classes that can be static would
_have_ to be static, or not be nested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 234533)
Time Spent: 5h 20m (was: 5h 10m)
> Upgrade errorprone compiler dependency to 2.3.3 and review the new warnings
> ---------------------------------------------------------------------------
>
> Key: ARTEMIS-2320
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2320
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.7.0
> Reporter: Jiri Daněk
> Priority: Minor
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
