[
https://issues.apache.org/jira/browse/ARTEMIS-2320?focusedWorklogId=234344&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-234344
]
ASF GitHub Bot logged work on ARTEMIS-2320:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/Apr/19 07:28
Start Date: 29/Apr/19 07:28
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on issue #2651:
ARTEMIS-2320 Fix ClassCanBeStatic errorprone warning
URL: https://github.com/apache/activemq-artemis/pull/2651#issuecomment-487476310
I agree about tone. And thats why i did not say MUST , and instead used
SHOULD which means ideally but if not sensible or possible then it doesnt have
to.
What seems to be the case here is a blanket of changing of classes but
without looking at what can be split out properly, only keeping those as nested
classes where sensible. As in not a single class in this PR has become a class
in its own right. I find that hard to believe
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 234344)
Time Spent: 4h 10m (was: 4h)
> Upgrade errorprone compiler dependency to 2.3.3 and review the new warnings
> ---------------------------------------------------------------------------
>
> Key: ARTEMIS-2320
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2320
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Affects Versions: 2.7.0
> Reporter: Jiri Daněk
> Priority: Minor
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
