[ https://issues.apache.org/jira/browse/ARTEMIS-3057?focusedWorklogId=669576&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-669576 ]
ASF GitHub Bot logged work on ARTEMIS-3057: ------------------------------------------- Author: ASF GitHub Bot Created on: 25/Oct/21 14:41 Start Date: 25/Oct/21 14:41 Worklog Time Spent: 10m Work Description: gemmellr commented on pull request #3812: URL: https://github.com/apache/activemq-artemis/pull/3812#issuecomment-950999165 {quote} I would probably make them mutually exclusive personally, as they will most likely never agree exactly on when to block and unblock so it seems odd to set both. Although that could be awkward since max-disk-usage has a built in default, so its currently 'almost always set' in a way, and your PR currently proposes having a default for the 'min available' too. {quote} To handle that I guess I would leave the existing max-disk-usage default to retain existing behaviour, and remove any default for the new 'min available' config. That way you know it was configured explicitly if it is set, and we could choose to document that it takes precedence over the max-disk-usage setting, i.e they can choose to use 'max-disk-usage' or to instead use 'min-disk-...' -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 669576) Time Spent: 40m (was: 0.5h) > Provide alternative to max-disk-usage to measure by remaining disk free > ----------------------------------------------------------------------- > > Key: ARTEMIS-3057 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3057 > Project: ActiveMQ Artemis > Issue Type: New Feature > Components: Broker > Affects Versions: 2.16.0 > Reporter: Barnaby Court > Priority: Major > Labels: easy > Time Spent: 40m > Remaining Estimate: 0h > > Today we can specify max-disk-usage as a percentage of disk that may be used > before blocking the queues. I believe this is done in order to prevent > journal corruption. Currently the value can be specified as a percentage > which works well for relatively small disks. When working on large systems > with many terabytes of storage even specifying 99% is going to result in > queues being blocked when there are still many gigabytes of disk space > remaining. > It would be very helpful to have an alternative version of the max-disk-usage > that allowed us to specify the threshold below which blocking should be > activated. For example, min-disk-available set to something like 500 > megabytes or 1 gigabyte before blocking the queues. -- This message was sent by Atlassian Jira (v8.3.4#803005)