[
https://issues.apache.org/jira/browse/ARTEMIS-3057?focusedWorklogId=670227&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-670227
]
ASF GitHub Bot logged work on ARTEMIS-3057:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Oct/21 16:47
Start Date: 26/Oct/21 16:47
Worklog Time Spent: 10m
Work Description: haanhvu edited a comment on pull request #3812:
URL: https://github.com/apache/activemq-artemis/pull/3812#issuecomment-952122872
@gemmellr
> Since the existing functionality uses 'max-disk-usage' as a name, I think
something like 'min-disk-...' would be more consistent than
'min-free-disk-bytes' is. I wouldn't put the 'bytes' units in the name,
allowing for more friendly unit-specifying strings to also be supplied, e.g. as
is supported for the "global-max-size".
Agree. I actually thought unit-specified strings would be better too. About
the name, does "min-free-disk" sound better?
> If allowing for units, a different route and obvious simplification to
avoid needing to consider any conflicting 'max usage' and 'min available'
configurations would be to instead just extend what the existing
'max-disk-usage' can do and allow it to specify the actual usage amount rather
than a percentage of the total.
This is of course a simpler way. However, it will force users to make a
calculation of the actual usage amount. Also, users will need to update this
value every time their disk size increases. With "min-free-disk", users don't
have to do those. So I still vote for "min-free-disk" as a better choice.
> To handle that I guess I would leave the existing max-disk-usage default
to retain existing behaviour, and remove any default for the new 'min
available' config. That way you know it was configured explicitly if it is set,
and we could choose to document that it takes precedence over the
max-disk-usage setting, i.e they can choose to use 'max-disk-usage' or to
instead use 'min-disk-...'
I think this approach is the optimal one now. I'll implement it. If I'm
stuck somewhere, I'll ping you.
Do you agree?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 670227)
Time Spent: 1h 20m (was: 1h 10m)
> Provide alternative to max-disk-usage to measure by remaining disk free
> -----------------------------------------------------------------------
>
> Key: ARTEMIS-3057
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3057
> Project: ActiveMQ Artemis
> Issue Type: New Feature
> Components: Broker
> Affects Versions: 2.16.0
> Reporter: Barnaby Court
> Priority: Major
> Labels: easy
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Today we can specify max-disk-usage as a percentage of disk that may be used
> before blocking the queues. I believe this is done in order to prevent
> journal corruption. Currently the value can be specified as a percentage
> which works well for relatively small disks. When working on large systems
> with many terabytes of storage even specifying 99% is going to result in
> queues being blocked when there are still many gigabytes of disk space
> remaining.
> It would be very helpful to have an alternative version of the max-disk-usage
> that allowed us to specify the threshold below which blocking should be
> activated. For example, min-disk-available set to something like 500
> megabytes or 1 gigabyte before blocking the queues.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
