[ https://issues.apache.org/jira/browse/ARTEMIS-3057?focusedWorklogId=672614&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-672614 ]
ASF GitHub Bot logged work on ARTEMIS-3057: ------------------------------------------- Author: ASF GitHub Bot Created on: 01/Nov/21 10:55 Start Date: 01/Nov/21 10:55 Worklog Time Spent: 10m Work Description: haanhvu commented on a change in pull request #3812: URL: https://github.com/apache/activemq-artemis/pull/3812#discussion_r740124331 ########## File path: tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/GlobalDiskFullTest.java ########## @@ -51,11 +51,19 @@ public void tick(long usableSpace, long totalSpace) { } @Override - public void over(long usableSpace, long totalSpace) { Review comment: @clebertsuconic for max-disk-usage, over means violate. But for min-disk-free, over means ok (not violate). I know changing a method name of a public interface can be a flag. But I did it for the sake of clarification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 672614) Time Spent: 2h 20m (was: 2h 10m) > Provide alternative to max-disk-usage to measure by remaining disk free > ----------------------------------------------------------------------- > > Key: ARTEMIS-3057 > URL: https://issues.apache.org/jira/browse/ARTEMIS-3057 > Project: ActiveMQ Artemis > Issue Type: New Feature > Components: Broker > Affects Versions: 2.16.0 > Reporter: Barnaby Court > Priority: Major > Labels: easy > Time Spent: 2h 20m > Remaining Estimate: 0h > > Today we can specify max-disk-usage as a percentage of disk that may be used > before blocking the queues. I believe this is done in order to prevent > journal corruption. Currently the value can be specified as a percentage > which works well for relatively small disks. When working on large systems > with many terabytes of storage even specifying 99% is going to result in > queues being blocked when there are still many gigabytes of disk space > remaining. > It would be very helpful to have an alternative version of the max-disk-usage > that allowed us to specify the threshold below which blocking should be > activated. For example, min-disk-available set to something like 500 > megabytes or 1 gigabyte before blocking the queues. -- This message was sent by Atlassian Jira (v8.3.4#803005)