[
https://issues.apache.org/jira/browse/AMQ-8412?focusedWorklogId=721661&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-721661
]
ASF GitHub Bot logged work on AMQ-8412:
---------------------------------------
Author: ASF GitHub Bot
Created on: 06/Feb/22 16:17
Start Date: 06/Feb/22 16:17
Worklog Time Spent: 10m
Work Description: cshannon commented on a change in pull request #756:
URL: https://github.com/apache/activemq/pull/756#discussion_r800201575
##########
File path:
activemq-client/src/main/java/org/apache/activemq/util/JMSExceptionSupport.java
##########
@@ -61,6 +63,9 @@ public static JMSException create(Exception cause) {
if (cause instanceof JMSException) {
return (JMSException)cause;
}
+ if (MaxFrameSizeException.class.isAssignableFrom(cause.getClass())) {
Review comment:
I would use instanceof here instead. isAssignableFrom is a dynamic call
vs compile time so the performance is slightly worse.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 721661)
Time Spent: 1h 40m (was: 1.5h)
> Return a well-formed response to clients when max message size is sent
> ----------------------------------------------------------------------
>
> Key: AMQ-8412
> URL: https://issues.apache.org/jira/browse/AMQ-8412
> Project: ActiveMQ
> Issue Type: New Feature
> Components: JMS client
> Reporter: Matt Pavlovich
> Assignee: Jean-Baptiste Onofré
> Priority: Major
> Fix For: 5.17.0, 5.16.4
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Currently, clients get an inconclusive exception when a message that is too
> large is sent. We should send a well-formed message, and then close.
> Options:
> 1. Change the current IOException to something else to fall within existing
> exception flow
> 2. Update current exception handling to send ExceptionResponse w/ the max
> message size message to the client before closing
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
