[jira] [Work logged] (AMQ-8412) Return a well-formed response to clients when max message size is sent

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/AMQ-8412?focusedWorklogId=721699&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-721699
 ]

ASF GitHub Bot logged work on AMQ-8412:
---------------------------------------

                Author: ASF GitHub Bot
            Created on: 06/Feb/22 22:18
            Start Date: 06/Feb/22 22:18
    Worklog Time Spent: 10m 
      Work Description: cshannon commented on a change in pull request #756:
URL: https://github.com/apache/activemq/pull/756#discussion_r800240683



##########
File path: 
activemq-client/src/main/java/org/apache/activemq/util/JMSExceptionSupport.java
##########
@@ -61,6 +63,11 @@ public static JMSException create(Exception cause) {
         if (cause instanceof JMSException) {
             return (JMSException)cause;
         }
+        if (cause instanceof MaxFrameSizeExceededException) {
+            JMSException jmsException = new JMSException(cause.getMessage(), 
"41300");
+            jmsException.setLinkedException(cause);

Review comment:
       Instead of using linked I would use initCause() as thats what the server 
side does.  A server side error thrown will have a 
TransportDisposedIOExceptionset when calling e.getCause() so it would be 
consistent




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 721699)
    Time Spent: 3h 20m  (was: 3h 10m)

> Return a well-formed response to clients when max message size is sent
> ----------------------------------------------------------------------
>
>                 Key: AMQ-8412
>                 URL: https://issues.apache.org/jira/browse/AMQ-8412
>             Project: ActiveMQ
>          Issue Type: New Feature
>          Components: JMS client
>            Reporter: Matt Pavlovich
>            Assignee: Jean-Baptiste Onofré
>            Priority: Major
>             Fix For: 5.17.0, 5.16.4
>
>          Time Spent: 3h 20m
>  Remaining Estimate: 0h
>
> Currently, clients get an inconclusive exception when a message that is too 
> large is sent. We should send a well-formed message, and then close.
> Options: 
> 1. Change the current IOException to something else to fall within existing 
> exception flow
> 2. Update current exception handling to send ExceptionResponse w/ the max 
> message size message to the client before closing



--
This message was sent by Atlassian Jira
(v8.20.1#820001)