[
https://issues.apache.org/jira/browse/AMQ-8412?focusedWorklogId=721668&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-721668
]
ASF GitHub Bot logged work on AMQ-8412:
---------------------------------------
Author: ASF GitHub Bot
Created on: 06/Feb/22 17:00
Start Date: 06/Feb/22 17:00
Worklog Time Spent: 10m
Work Description: mattrpav commented on a change in pull request #756:
URL: https://github.com/apache/activemq/pull/756#discussion_r800206637
##########
File path:
activemq-client/src/main/java/org/apache/activemq/MaxFrameSizeException.java
##########
@@ -0,0 +1,31 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.activemq;
+
+import java.io.IOException;
+/**
+ * An exception thrown when max frame size is exceeded.
+ *
+ *
+ */
+public class MaxFrameSizeException extends IOException {
+ private static final long serialVersionUID = -7681404582227153308L;
+
+ public MaxFrameSizeException(String message) {
Review comment:
done.
##########
File path:
activemq-client/src/main/java/org/apache/activemq/util/JMSExceptionSupport.java
##########
@@ -61,6 +63,9 @@ public static JMSException create(Exception cause) {
if (cause instanceof JMSException) {
return (JMSException)cause;
}
+ if (MaxFrameSizeException.class.isAssignableFrom(cause.getClass())) {
Review comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 721668)
Time Spent: 2h 10m (was: 2h)
> Return a well-formed response to clients when max message size is sent
> ----------------------------------------------------------------------
>
> Key: AMQ-8412
> URL: https://issues.apache.org/jira/browse/AMQ-8412
> Project: ActiveMQ
> Issue Type: New Feature
> Components: JMS client
> Reporter: Matt Pavlovich
> Assignee: Jean-Baptiste Onofré
> Priority: Major
> Fix For: 5.17.0, 5.16.4
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Currently, clients get an inconclusive exception when a message that is too
> large is sent. We should send a well-formed message, and then close.
> Options:
> 1. Change the current IOException to something else to fall within existing
> exception flow
> 2. Update current exception handling to send ExceptionResponse w/ the max
> message size message to the client before closing
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
