[
https://issues.apache.org/jira/browse/ARTEMIS-4349?focusedWorklogId=870384&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-870384
]
ASF GitHub Bot logged work on ARTEMIS-4349:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jul/23 16:38
Start Date: 11/Jul/23 16:38
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #4540:
URL: https://github.com/apache/activemq-artemis/pull/4540#discussion_r1259992802
##########
pom.xml:
##########
@@ -1097,6 +1094,13 @@
<arg>-XDcompilePolicy=simple</arg>
<arg>-Xplugin:ErrorProne
-Xep:ThreadLocalUsage:ERROR -Xep:MissingOverride:ERROR
-Xep:NonAtomicVolatileUpdate:ERROR -Xep:SynchronizeOnNonFinalField:ERROR
-Xep:StaticQualifiedUsingExpression:ERROR -Xep:WaitNotInLoop:ERROR
-Xep:BanJNDI:OFF -XepExcludedPaths:.*/generated-sources/.*</arg>
</compilerArgs>
+ <annotationProcessorPaths>
+ <path>
+ <groupId>com.google.errorprone</groupId>
+ <artifactId>error_prone_core</artifactId>
+ <version>${errorprone.version}</version>
+ </path>
+ </annotationProcessorPaths>
Review Comment:
I'd guess because it is doing a completely different thing there, with the
ErrorProne deps defined earlier off-classpath, likely meaning its transitive
guava dep version gets picked up, before starting to look at the compile deps
on the classpath...rather than the reverse in the profile case. Which is fine
if you dont remove the dependencyManagement entries ensuring the desired
versions are chosen.
Issue Time Tracking
-------------------
Worklog Id: (was: 870384)
Time Spent: 5.5h (was: 5h 20m)
> Replace Guava cache with Caffeine
> ---------------------------------
>
> Key: ARTEMIS-4349
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4349
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.29.0
> Reporter: Alexey Markevich
> Priority: Major
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> based on benchmark https://github.com/ben-manes/caffeine/wiki/Benchmarks
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
