[
https://issues.apache.org/jira/browse/ARTEMIS-4349?focusedWorklogId=877344&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877344
]
ASF GitHub Bot logged work on ARTEMIS-4349:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Aug/23 16:50
Start Date: 21/Aug/23 16:50
Worklog Time Spent: 10m
Work Description: gemmellr opened a new pull request, #4584:
URL: https://github.com/apache/activemq-artemis/pull/4584
As it has been several weeks of the overall Caffeine related changes not
progressing due to largely unrelated issues and despite some simple fixups that
would let them, I decided to update PR #4540 myself and raise a new PR.
I have kept the original changes and my followups in separate commits here
to make the alterations easier to see. We can squash all the updates upon PR
completion before the push.
This now concentrates more on the simple 'adding Caffeine for caching' side
the JIRA is actually for, and unwinds some of the earlier changes so as to fix
the console build issue they introduced and also not breaking the overall
[ErrorProne-enabled] build as they do (without other/additional changes like
#4545 or #4567 first to partially-avoid the issues being introduced). In the
end I also decided to skip introducing the classgraph dep or adjusting the
related test, instead just having the test continue to use the Guava dep since
that is still/already being used elsewhere in the build anyway.
The PR builds pass on these changes, and I ran a full test suite run on them.
Issue Time Tracking
-------------------
Worklog Id: (was: 877344)
Time Spent: 7h (was: 6h 50m)
> Replace Guava cache with Caffeine
> ---------------------------------
>
> Key: ARTEMIS-4349
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4349
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.29.0
> Reporter: Alexey Markevich
> Priority: Major
> Time Spent: 7h
> Remaining Estimate: 0h
>
> based on benchmark https://github.com/ben-manes/caffeine/wiki/Benchmarks
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
