[
https://issues.apache.org/jira/browse/ARTEMIS-4349?focusedWorklogId=877346&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-877346
]
ASF GitHub Bot logged work on ARTEMIS-4349:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Aug/23 16:52
Start Date: 21/Aug/23 16:52
Worklog Time Spent: 10m
Work Description: gemmellr commented on PR #4584:
URL:
https://github.com/apache/activemq-artemis/pull/4584#issuecomment-1686688047
This still isnt necesarily complete yet however, there is one other thing
that I just noticed about the changes that is worth looking into first.
The removal of Guava from artemis-server has seemingly made these changes
alter the resulting assembly more than simply adding the additional Caffeine
dep, instead adding multiple other jars that were not present before. I expect
this is as the Guava dependency in artemis-server previously also excluded
various transitve deps from Guava, and the artemis-server dependency then
dominated in most (but perhaps not all) of the other modules in the build, so
the exclusions then applied there also. With removal of that dep from
artemis-server the transitive Guava dependency from artemis-quorum-ri is
instead surfacing as the new route-to-Guava (via curator-client) and as that
module didnt have the same excludes it is presumably now bringing the further
dependencies into artemis-distribution unlike before.
An additional change still to try out is thus whether making the same
excludes (build/checker annotation related deps) for artemis-quorum-ri works
ok, and if so making them to return the assembly to its previous state + just
adding Caffeine as it seemed this would.
Issue Time Tracking
-------------------
Worklog Id: (was: 877346)
Time Spent: 7h 10m (was: 7h)
> Replace Guava cache with Caffeine
> ---------------------------------
>
> Key: ARTEMIS-4349
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4349
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Affects Versions: 2.29.0
> Reporter: Alexey Markevich
> Priority: Major
> Time Spent: 7h 10m
> Remaining Estimate: 0h
>
> based on benchmark https://github.com/ben-manes/caffeine/wiki/Benchmarks
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
