[
https://issues.apache.org/jira/browse/ARTEMIS-4758?focusedWorklogId=917333&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917333
]
ASF GitHub Bot logged work on ARTEMIS-4758:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/May/24 16:37
Start Date: 02/May/24 16:37
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #4918:
URL: https://github.com/apache/activemq-artemis/pull/4918#discussion_r1587950084
##########
artemis-commons/src/main/java/org/apache/activemq/artemis/core/server/ActiveMQScheduledComponent.java:
##########
@@ -212,15 +212,19 @@ public long getPeriod() {
}
public synchronized ActiveMQScheduledComponent setPeriod(long period) {
- this.period = period;
- restartIfNeeded();
+ if (this.period != period) {
+ this.period = period;
+ restartIfNeeded();
+ }
return this;
}
public synchronized ActiveMQScheduledComponent setPeriod(long period,
TimeUnit unit) {
- this.period = period;
- this.timeUnit = unit;
- restartIfNeeded();
+ if (this.period != period && this.timeUnit != unit) {
Review Comment:
Yeah... there's a bug in here...
which means I'm not testing this :)
Will add a test
Issue Time Tracking
-------------------
Worklog Id: (was: 917333)
Time Spent: 40m (was: 0.5h)
> Hardening Mirroring
> -------------------
>
> Key: ARTEMIS-4758
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4758
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Clebert Suconic
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> I have been extensively testing mirroring, and I'm hardening it as an overal
> task, improving its behavior:
> - Page Transactions on mirror target are now optional.
> * If you had an interrupt mirror while the target destination was paging,
> duplicate detection would be ineffective unless you used paged transactions
> * Users can now configure the ack manager retries intervals.
> Say you need some time to remove a consumer from a target mirror. The
> delivering references would prevent acks from happening. You can allow bigger
> retry intervals and number of retries by tinkiering with ack manager retry
> parameters.
> * The ackManager was only restarted when new acks were coming in. If you
> stopped receiving acks on a target server and restarted that server with
> pending acks, those acks would never be exercised. The AckManager retries are
> now restarted as soon as the server is started.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
