[ 
https://issues.apache.org/jira/browse/ARTEMIS-4758?focusedWorklogId=917346&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917346
 ]

ASF GitHub Bot logged work on ARTEMIS-4758:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/May/24 17:52
            Start Date: 02/May/24 17:52
    Worklog Time Spent: 10m 
      Work Description: clebertsuconic commented on code in PR #4918:
URL: https://github.com/apache/activemq-artemis/pull/4918#discussion_r1588051242


##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/transaction/Transaction.java:
##########
@@ -109,4 +109,8 @@ enum State {
 
    /** To be used on control transactions that are meant as internal and don't 
really require a hard sync. */
    Transaction setAsync(boolean async);
+
+   default boolean isAllowPageTransaction() {
+      return true;
+   }

Review Comment:
   MirrorTransactions will disable page transaction by default. 
   
   I have corrected the names





Issue Time Tracking
-------------------

    Worklog Id:     (was: 917346)
    Time Spent: 50m  (was: 40m)

> Hardening Mirroring
> -------------------
>
>                 Key: ARTEMIS-4758
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4758
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Clebert Suconic
>            Priority: Major
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> I have been extensively testing mirroring, and I'm hardening it as an overal 
> task, improving its behavior:
> - Page Transactions on mirror target are now optional.
>   * If you had an interrupt mirror while the target destination was paging, 
> duplicate detection would be ineffective unless you used paged transactions
>   * Users can now configure the ack manager retries intervals.
>       Say you need some time to remove a consumer from a target mirror. The 
> delivering references would prevent acks from happening. You can allow bigger 
> retry intervals and number of retries by tinkiering with ack manager retry 
> parameters.
>   * The ackManager was only restarted when new acks were coming in. If you 
> stopped receiving acks on a target server and restarted that server with 
> pending acks, those acks would never be exercised. The AckManager retries are 
> now restarted as soon as the server is started.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to