[
https://issues.apache.org/jira/browse/ARTEMIS-4758?focusedWorklogId=917417&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-917417
]
ASF GitHub Bot logged work on ARTEMIS-4758:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 03/May/24 04:31
Start Date: 03/May/24 04:31
Worklog Time Spent: 10m
Work Description: brusdev commented on code in PR #4918:
URL: https://github.com/apache/activemq-artemis/pull/4918#discussion_r1588635621
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/broker/ProtonProtocolManagerFactory.java:
##########
@@ -87,7 +87,8 @@ public String getModuleName() {
@Override
public void loadProtocolServices(ActiveMQServer server,
List<ActiveMQComponent> services) {
try {
- AckManager ackManager = AckManagerProvider.getManager(server, false);
+ AckManager ackManager = AckManagerProvider.getManager(server);
+ services.add(ackManager);
Review Comment:
It seems that the same instance of the AckManager could be added multiple
times to the list of services.
Issue Time Tracking
-------------------
Worklog Id: (was: 917417)
Time Spent: 1h 20m (was: 1h 10m)
> Hardening Mirroring
> -------------------
>
> Key: ARTEMIS-4758
> URL: https://issues.apache.org/jira/browse/ARTEMIS-4758
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Reporter: Clebert Suconic
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> I have been extensively testing mirroring, and I'm hardening it as an overal
> task, improving its behavior:
> - Page Transactions on mirror target are now optional.
> * If you had an interrupt mirror while the target destination was paging,
> duplicate detection would be ineffective unless you used paged transactions
> * Users can now configure the ack manager retries intervals.
> Say you need some time to remove a consumer from a target mirror. The
> delivering references would prevent acks from happening. You can allow bigger
> retry intervals and number of retries by tinkiering with ack manager retry
> parameters.
> * The ackManager was only restarted when new acks were coming in. If you
> stopped receiving acks on a target server and restarted that server with
> pending acks, those acks would never be exercised. The AckManager retries are
> now restarted as soon as the server is started.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
