[
https://issues.apache.org/jira/browse/ARTEMIS-5266?focusedWorklogId=954460&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-954460
]
ASF GitHub Bot logged work on ARTEMIS-5266:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/Jan/25 15:48
Start Date: 29/Jan/25 15:48
Worklog Time Spent: 10m
Work Description: gemmellr commented on code in PR #5477:
URL: https://github.com/apache/activemq-artemis/pull/5477#discussion_r1934136940
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/JsonUtil.java:
##########
@@ -70,24 +69,22 @@ public static Object[] fromJsonArray(final JsonArray
jsonArray) throws Exception
for (String key : keys) {
Object innerVal = jsonObject.get(key);
- if (innerVal instanceof JsonArray) {
- innerVal = fromJsonArray(((JsonArray) innerVal));
- } else if (innerVal instanceof JsonString) {
- innerVal = ((JsonString) innerVal).getString();
+ if (innerVal instanceof JsonArray jsonArray1) {
+ innerVal = fromJsonArray(jsonArray1);
+ } else if (innerVal instanceof JsonString string) {
+ innerVal = string.getString();
Review Comment:
```suggestion
if (innerVal instanceof JsonArray innerJsonArray) {
innerVal = fromJsonArray(innerJsonArray);
} else if (innerVal instanceof JsonString innerJsonString) {
innerVal = innerJsonString.getString();
```
Issue Time Tracking
-------------------
Worklog Id: (was: 954460)
Time Spent: 1h (was: 50m)
> Code gardening after move to Java 17
> ------------------------------------
>
> Key: ARTEMIS-5266
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5266
> Project: ActiveMQ Artemis
> Issue Type: Task
> Reporter: Justin Bertram
> Assignee: Justin Bertram
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> With the recent move to Java 17 now is a good time to do some code gardening
> to leverage new language features (e.g. text blocks) and deal with old issue
> (e.g. unused variables, etc.).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
