[ 
https://issues.apache.org/jira/browse/ARTEMIS-5266?focusedWorklogId=954507&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-954507
 ]

ASF GitHub Bot logged work on ARTEMIS-5266:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 29/Jan/25 17:10
            Start Date: 29/Jan/25 17:10
    Worklog Time Spent: 10m 
      Work Description: gemmellr commented on code in PR #5477:
URL: https://github.com/apache/activemq-artemis/pull/5477#discussion_r1934276931


##########
artemis-jms-client/src/main/java/org/apache/activemq/artemis/jms/client/ActiveMQSession.java:
##########
@@ -634,8 +634,8 @@ public MessageConsumer createSharedConsumer(Topic topic, 
String name, String mes
       }
       checkTopic(topic);
       ActiveMQTopic localTopic;
-      if (topic instanceof ActiveMQTopic) {
-         localTopic = (ActiveMQTopic) topic;
+      if (topic instanceof ActiveMQTopic qTopic) {

Review Comment:
   qException was strange, but qTopic is about the most nonsense thing it could 
have picked :)
   
   Here and all the others below





Issue Time Tracking
-------------------

    Worklog Id:     (was: 954507)
    Time Spent: 2h 10m  (was: 2h)

> Code gardening after move to Java 17
> ------------------------------------
>
>                 Key: ARTEMIS-5266
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-5266
>             Project: ActiveMQ Artemis
>          Issue Type: Task
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> With the recent move to Java 17 now is a good time to do some code gardening 
> to leverage new language features (e.g. text blocks) and deal with old issue 
> (e.g. unused variables, etc.).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to