[ 
https://issues.apache.org/jira/browse/ARTEMIS-5266?focusedWorklogId=954509&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-954509
 ]

ASF GitHub Bot logged work on ARTEMIS-5266:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 29/Jan/25 17:14
            Start Date: 29/Jan/25 17:14
    Worklog Time Spent: 10m 
      Work Description: gemmellr commented on code in PR #5477:
URL: https://github.com/apache/activemq-artemis/pull/5477#discussion_r1934284140


##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/mirror/AMQPMirrorControllerSource.java:
##########
@@ -510,8 +510,8 @@ private static void setProtocolData(MessageReference ref, 
String brokerID, long
    }
 
    private static Properties getProperties(Message message) {
-      if (message instanceof AMQPMessage) {
-         return 
AMQPMessageBrokerAccessor.getCurrentProperties((AMQPMessage)message);
+      if (message instanceof AMQPMessage pMessage) {
+         return AMQPMessageBrokerAccessor.getCurrentProperties(pMessage);

Review Comment:
   ```suggestion
         if (message instanceof AMQPMessage amqpMessage) {
            return AMQPMessageBrokerAccessor.getCurrentProperties(amqpMessage);
   ```





Issue Time Tracking
-------------------

    Worklog Id:     (was: 954509)
    Time Spent: 2.5h  (was: 2h 20m)

> Code gardening after move to Java 17
> ------------------------------------
>
>                 Key: ARTEMIS-5266
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-5266
>             Project: ActiveMQ Artemis
>          Issue Type: Task
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> With the recent move to Java 17 now is a good time to do some code gardening 
> to leverage new language features (e.g. text blocks) and deal with old issue 
> (e.g. unused variables, etc.).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact


Reply via email to