[
https://issues.apache.org/jira/browse/ARTEMIS-3915?focusedWorklogId=982458&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-982458
]
ASF GitHub Bot logged work on ARTEMIS-3915:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Sep/25 16:29
Start Date: 09/Sep/25 16:29
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #5908:
URL: https://github.com/apache/activemq-artemis/pull/5908#discussion_r2334175593
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/ProtocolHandler.java:
##########
@@ -184,7 +208,9 @@ public void channelRead(ChannelHandlerContext ctx, Object
msg) throws Exception
ctx.writeAndFlush(new DefaultFullHttpResponse(HTTP_1_1,
FORBIDDEN)).addListener(ChannelFutureListener.CLOSE);
}
} else {
- super.channelRead(ctx, msg);
+ // slice off the proxy-related bytes that have already been read
so other protocol handlers don't choke on them
+ super.channelRead(ctx, skipProxyBytes ? ((ByteBuf) msg).slice() :
msg);
+ skipProxyBytes = false;
Review Comment:
I refactored the logic into a customer handler.
FWIW, AFAICT this was actually required in order to get the SSL stuff to
work.
Issue Time Tracking
-------------------
Worklog Id: (was: 982458)
Time Spent: 5h 20m (was: 5h 10m)
> Support PROXY Protocol
> ----------------------
>
> Key: ARTEMIS-3915
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3915
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Reporter: João Santos
> Assignee: Justin Bertram
> Priority: Major
> Labels: pull-request-available
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> [HAProxy|http://www.haproxy.org/] is a widely known and used TCP Load
> Balancer and especially useful for an ActiveMQ Artemis clustered environment.
> Although possible to functionally implement with both products current
> features, Artemis does not support the PROXY protocol, which prevents it's
> broker nodes from inferring the real remote client IP address when behind an
> HAProxy instance.
> Since Netty sockets implementation already seems to support this protocol
> (discussed w/ [~jbertram] on DEV mailing list), it shouldn't be a big leap to
> adding support for the protocol on Artemis acceptors, thus improving the
> deployment of the use case at hand.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
