[
https://issues.apache.org/jira/browse/ARTEMIS-3915?focusedWorklogId=982314&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-982314
]
ASF GitHub Bot logged work on ARTEMIS-3915:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Sep/25 16:11
Start Date: 08/Sep/25 16:11
Worklog Time Spent: 10m
Work Description: jbertram commented on code in PR #5908:
URL: https://github.com/apache/activemq-artemis/pull/5908#discussion_r2330719780
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/TransportConstants.java:
##########
@@ -36,6 +36,8 @@ public class TransportConstants {
public static final String SSL_ENABLED_PROP_NAME = "sslEnabled";
+ public static final String PROXY_ENABLED_PROP_NAME = "proxyEnabled";
Review Comment:
Done.
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/TransportConstants.java:
##########
@@ -186,26 +188,28 @@ public class TransportConstants {
public static final int STOMP_DEFAULT_CONSUMER_WINDOW_SIZE = 10 * 1024; //
10K
- public static final String PROXY_ENABLED_PROP_NAME = "socksEnabled";
+ public static final String SOCKS_ENABLED_PROP_NAME = "socksEnabled";
- public static final String PROXY_HOST_PROP_NAME = "socksHost";
+ public static final String SOCKS_HOST_PROP_NAME = "socksHost";
- public static final String PROXY_PORT_PROP_NAME = "socksPort";
+ public static final String SOCKS_PORT_PROP_NAME = "socksPort";
public static final String PROXY_VERSION_PROP_NAME = "socksVersion";
- public static final String PROXY_USERNAME_PROP_NAME = "socksUsername";
+ public static final String SOCKS_USERNAME_PROP_NAME = "socksUsername";
- public static final String PROXY_PASSWORD_PROP_NAME = "socksPassword";
+ public static final String SOCKS_PASSWORD_PROP_NAME = "socksPassword";
- public static final String PROXY_REMOTE_DNS_PROP_NAME = "socksRemoteDNS";
+ public static final String SOCKS_REMOTE_DNS_PROP_NAME = "socksRemoteDNS";
public static final String AUTO_START = "autoStart";
public static final boolean DEFAULT_AUTO_START = true;
public static final boolean DEFAULT_SSL_ENABLED = false;
+ public static final boolean DEFAULT_PROXY_ENABLED = false;
Review Comment:
Done.
Issue Time Tracking
-------------------
Worklog Id: (was: 982314)
Time Spent: 4h 20m (was: 4h 10m)
> Support PROXY Protocol
> ----------------------
>
> Key: ARTEMIS-3915
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3915
> Project: ActiveMQ Artemis
> Issue Type: Improvement
> Components: Broker
> Reporter: João Santos
> Assignee: Justin Bertram
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
> [HAProxy|http://www.haproxy.org/] is a widely known and used TCP Load
> Balancer and especially useful for an ActiveMQ Artemis clustered environment.
> Although possible to functionally implement with both products current
> features, Artemis does not support the PROXY protocol, which prevents it's
> broker nodes from inferring the real remote client IP address when behind an
> HAProxy instance.
> Since Netty sockets implementation already seems to support this protocol
> (discussed w/ [~jbertram] on DEV mailing list), it shouldn't be a big leap to
> adding support for the protocol on Artemis acceptors, thus improving the
> deployment of the use case at hand.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
