[
https://issues.apache.org/jira/browse/AMQ-9392?focusedWorklogId=990302&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-990302
]
ASF GitHub Bot logged work on AMQ-9392:
---------------------------------------
Author: ASF GitHub Bot
Created on: 04/Nov/25 19:50
Start Date: 04/Nov/25 19:50
Worklog Time Spent: 10m
Work Description: cshannon commented on PR #1119:
URL: https://github.com/apache/activemq/pull/1119#issuecomment-3487776325
I've been looking over this PR and issue in preparation of the 6.2.0 release
and I think we should target for 6.3.0 instead.
There is definitely an issue here with the timer being leaked, but I'm not
convinced the fix is quite right. For example, the null checks don't make sense
to me where they were added because directly before the checks the same
variables are reference without a null check. Another issue is I think the fix
could cause it to inadvertently miss shutting down the write task now but not
sure. A third issue is it's normal to close the connect task before starting
the monitor threads so this patch might destroy the thread pool just to
immediately re-create it again if there are no other connections.
Also, I was playing around and testing concurrent connections and I found
that while this patch improved things a bit, the read task can still be leak if
a connection is closed immediately after creating (before it finishes
initialization) because a socket read error can be thrown and that IOException
was causing the inactivity monitor logic that does to the close to be skipped
(pre-existing thing and unrelated to this patch).
So, i think we should just spend some more time on it as this code is high
risk to change because it affects every connection
Issue Time Tracking
-------------------
Worklog Id: (was: 990302)
Time Spent: 1.5h (was: 1h 20m)
> Prevent InactivityMonitor read check Timer leak when TCP connection fails
> -------------------------------------------------------------------------
>
> Key: AMQ-9392
> URL: https://issues.apache.org/jira/browse/AMQ-9392
> Project: ActiveMQ Classic
> Issue Type: Improvement
> Reporter: Matt Pavlovich
> Assignee: Jean-Baptiste Onofré
> Priority: Minor
> Fix For: 6.3.0, 6.2.1
>
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Reported by Github user Axel Sanguinetti
> https://github.com/asanguinetti
> Description and PR provided:
> https://github.com/apache/activemq/pull/1119
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
