[
https://issues.apache.org/jira/browse/AMQ-9392?focusedWorklogId=990322&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-990322
]
ASF GitHub Bot logged work on AMQ-9392:
---------------------------------------
Author: ASF GitHub Bot
Created on: 04/Nov/25 23:51
Start Date: 04/Nov/25 23:51
Worklog Time Spent: 10m
Work Description: cshannon commented on PR #1119:
URL: https://github.com/apache/activemq/pull/1119#issuecomment-3488459204
> Also, I was playing around and testing concurrent connections and I found
that while this patch improved things a bit, the read task can still be leak if
a connection is closed immediately after creating (before it finishes
initialization) because a socket read error can be thrown and that IOException
was causing the inactivity monitor logic that does to the close to be skipped
(pre-existing thing and unrelated to this patch).
So this part may not be an issue after all, on exception I forgot that the
default transport listener will async stop connections so I don't think I
waited long enough for the cleanup but need to confirm. I think we need to
write some improved tests with whatever the final version of this patch is that
will concurrently create some connections with different states (some correct,
some hung, some that immediately close and test the condition being fixed here
etc). Note that we need a real integration test for this to use a real
transport that sets the correct listener for cleanup as the
InactivityMonitorTest just uses a custom test listener with the transport only
and not a broker so those tests are good but not complete.
Issue Time Tracking
-------------------
Worklog Id: (was: 990322)
Time Spent: 1h 40m (was: 1.5h)
> Prevent InactivityMonitor read check Timer leak when TCP connection fails
> -------------------------------------------------------------------------
>
> Key: AMQ-9392
> URL: https://issues.apache.org/jira/browse/AMQ-9392
> Project: ActiveMQ Classic
> Issue Type: Improvement
> Reporter: Matt Pavlovich
> Assignee: Jean-Baptiste Onofré
> Priority: Minor
> Fix For: 6.3.0, 6.2.1
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Reported by Github user Axel Sanguinetti
> https://github.com/asanguinetti
> Description and PR provided:
> https://github.com/apache/activemq/pull/1119
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
