[
https://issues.apache.org/jira/browse/AMQ-9392?focusedWorklogId=990426&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-990426
]
ASF GitHub Bot logged work on AMQ-9392:
---------------------------------------
Author: ASF GitHub Bot
Created on: 05/Nov/25 13:40
Start Date: 05/Nov/25 13:40
Worklog Time Spent: 10m
Work Description: cshannon opened a new pull request, #1529:
URL: https://github.com/apache/activemq/pull/1529
This commit updates the previous fix for preventing a read check Timer
leak by the inactivity monitor when TCP connections fail
This is a follow on to https://github.com/apache/activemq/pull/1119
This updated version has the following improvements:
1) The logic to cancel timers and shutdown the executor has been
consolidated into one location and only done during stopping of the
transport. Previously, the update could stop the task/executor during
normal broker operation (see next point)
2) stopConnectCheckTask() is called under normal circumstances during
initialization of a connection and the previous change caused the read
task to be cancelled and the executor to be stopped, only to be
immediately restarted again during the first connection creation.
3) Null checks were added to guarantee no null pointer issues when
referencing tasks/timers during stop
4) Helper methods and some comments were added to simplify the code
and make it easier to understand what is going on.
Issue Time Tracking
-------------------
Worklog Id: (was: 990426)
Time Spent: 2h (was: 1h 50m)
> Prevent InactivityMonitor read check Timer leak when TCP connection fails
> -------------------------------------------------------------------------
>
> Key: AMQ-9392
> URL: https://issues.apache.org/jira/browse/AMQ-9392
> Project: ActiveMQ Classic
> Issue Type: Improvement
> Reporter: Matt Pavlovich
> Assignee: Jean-Baptiste Onofré
> Priority: Minor
> Fix For: 6.3.0, 6.2.1
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Reported by Github user Axel Sanguinetti
> https://github.com/asanguinetti
> Description and PR provided:
> https://github.com/apache/activemq/pull/1119
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
For further information, visit: https://activemq.apache.org/contact
