[ https://issues.apache.org/jira/browse/ARROW-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16214471#comment-16214471 ]
ASF GitHub Bot commented on ARROW-1689: --------------------------------------- wesm commented on issue #1233: ARROW-1689 Allow User To Request No Data Copies URL: https://github.com/apache/arrow/pull/1233#issuecomment-338512386 pandas aggressively consolidates blocks. For non-categorical types, the maximum performance, most memory efficient choice for nearly all pandas users is to create pre-consolidated blocks. I’m a bit worried about doing significant work on this code without having ASV benchmarks set up ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [Python] Categorical Indices Should Be Zero-Copy > ------------------------------------------------ > > Key: ARROW-1689 > URL: https://issues.apache.org/jira/browse/ARROW-1689 > Project: Apache Arrow > Issue Type: Improvement > Components: Python > Affects Versions: 0.7.1 > Reporter: Nick White > Labels: pull-request-available > > It seems like > [WriteIndices|https://github.com/apache/arrow/blob/0c8b861f93884f2868eb631d8fceee3a8b8905ec/cpp/src/arrow/python/arrow_to_pandas.cc#L955-L981] > could reuse some of the logic in > [ConvertValuesZeroCopy|https://github.com/apache/arrow/blob/0c8b861f93884f2868eb631d8fceee3a8b8905ec/cpp/src/arrow/python/arrow_to_pandas.cc#L1348-L1385] > to avoid copying the integer indices array? -- This message was sent by Atlassian JIRA (v6.4.14#64029)