[
https://issues.apache.org/jira/browse/ARROW-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16214886#comment-16214886
]
ASF GitHub Bot commented on ARROW-1689:
---------------------------------------
njwhite commented on a change in pull request #1233: ARROW-1689 Allow User To
Request No Data Copies
URL: https://github.com/apache/arrow/pull/1233#discussion_r146215009
##########
File path: python/pyarrow/table.pxi
##########
@@ -159,7 +159,7 @@ cdef class Column:
sp_column.reset(new CColumn(boxed_field.sp_field, arr.sp_array))
return pyarrow_wrap_column(sp_column)
- def to_pandas(self, strings_to_categorical=False):
+ def to_pandas(self, strings_to_categorical=False, zero_copy_only=False):
Review comment:
@xhochy Makes sense, definitely want to keep this change focussed so should
I just remove the flag from `pa.Table`? I'll fix the AppVeyor complaints
tonight, & rebase off master to see if that fixes the other issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [Python] Categorical Indices Should Be Zero-Copy
> ------------------------------------------------
>
> Key: ARROW-1689
> URL: https://issues.apache.org/jira/browse/ARROW-1689
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Python
> Affects Versions: 0.7.1
> Reporter: Nick White
> Labels: pull-request-available
>
> It seems like
> [WriteIndices|https://github.com/apache/arrow/blob/0c8b861f93884f2868eb631d8fceee3a8b8905ec/cpp/src/arrow/python/arrow_to_pandas.cc#L955-L981]
> could reuse some of the logic in
> [ConvertValuesZeroCopy|https://github.com/apache/arrow/blob/0c8b861f93884f2868eb631d8fceee3a8b8905ec/cpp/src/arrow/python/arrow_to_pandas.cc#L1348-L1385]
> to avoid copying the integer indices array?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
