[ 
https://issues.apache.org/jira/browse/ARROW-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272241#comment-16272241
 ] 

ASF GitHub Bot commented on ARROW-1866:
---------------------------------------

BryanCutler commented on issue #1371: ARROW-1866: [Java] Combine MapVector 
classes and remove NonNullableMapVector
URL: https://github.com/apache/arrow/pull/1371#issuecomment-348100328
 
 
   @siddharthteotia just to be clear, the end result of this PR is to flatten 
the 2 map vectors classes into 1 `MapVector` and no functionality was added or 
removed.  If you prefer we revert back to these vectors before #1341 to assess 
the impact of the change in Dremio, then I'm ok with that.  Is it primarily a 
question of performance you would like to check?  My thought is that it would 
be good to be consistent with the rest of the vectors that no longer have a 
Nullable prefix and get as much of the refactoring done as possible for the 0.8 
release.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> [Java] Combine MapVector and NonNullableMapVector Classes
> ---------------------------------------------------------
>
>                 Key: ARROW-1866
>                 URL: https://issues.apache.org/jira/browse/ARROW-1866
>             Project: Apache Arrow
>          Issue Type: Sub-task
>          Components: Java - Vectors
>            Reporter: Bryan Cutler
>            Assignee: Bryan Cutler
>              Labels: pull-request-available
>             Fix For: 0.8.0
>
>
> {{NonNullableMapVector}} class can be merged into {{MapVector}} and removed 
> as part of removing the non nullable vectors.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to