[
https://issues.apache.org/jira/browse/ARROW-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273356#comment-16273356
]
ASF GitHub Bot commented on ARROW-1866:
---------------------------------------
BryanCutler commented on issue #1371: ARROW-1866: [Java] Combine MapVector
classes and remove NonNullableMapVector
URL: https://github.com/apache/arrow/pull/1371#issuecomment-348310872
This PR does not remove SingleMapWriter, but since it now uses the nullable
MapVector as the container, it is functionally equivalent to
NullableMapWriter.
On Nov 30, 2017 11:44 AM, "Li Jin" <[email protected]> wrote:
> Seems there are some code in Dremio that is going to be affected by
> removing non nullable MapVector and SingleMapWriter but not too many:
> (Hopefully this is up to date)
>
> https://github.com/dremio/dremio-oss/search?p=2&q=
> MapVector&type=&utf8=%E2%9C%93
> https://github.com/dremio/dremio-oss/search?utf8=%E2%9C%
> 93&q=SingleMapWriter&type=
>
> I don't know what's the best way to proceed. Maybe we can give it a couple
> of days for @siddharthteotia <https://github.com/siddharthteotia> to
> evaluate if removing non nullable vectors are OK for Dremio.
>
> Any thoughts?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/arrow/pull/1371#issuecomment-348299006>, or mute
> the thread
>
<https://github.com/notifications/unsubscribe-auth/AEUwdViMkgm6K1rWXuJUVdMDmhMaxmFtks5s7wWbgaJpZM4QuWKm>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Java] Combine MapVector and NonNullableMapVector Classes
> ---------------------------------------------------------
>
> Key: ARROW-1866
> URL: https://issues.apache.org/jira/browse/ARROW-1866
> Project: Apache Arrow
> Issue Type: Sub-task
> Components: Java - Vectors
> Reporter: Bryan Cutler
> Assignee: Bryan Cutler
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> {{NonNullableMapVector}} class can be merged into {{MapVector}} and removed
> as part of removing the non nullable vectors.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
