[
https://issues.apache.org/jira/browse/ARROW-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273223#comment-16273223
]
ASF GitHub Bot commented on ARROW-1866:
---------------------------------------
siddharthteotia commented on issue #1371: ARROW-1866: [Java] Combine MapVector
classes and remove NonNullableMapVector
URL: https://github.com/apache/arrow/pull/1371#issuecomment-348293303
My suggestion is to keep the old pair of NullableMapVector and MapVector as
is and just remove the new NonNullable* class -- basically let's have the
MapVector hierarchy back to what it was before with MapVector being the base
class and NullableMapVector being the subclass.
Since the implications of combining them are to the reader and writer as
well and @BryanCutler proposed to remove them, I would like to assess their
usage in Dremio. For example, we have a data structure writer called
VectorContainerWriter which has a MapVector inside and a SingleMapWriter to
populate the data structure.
I am just asking to keep these 2 vectors around as is for the time being.
Later on we can combine them and decide what to do with reader/writer.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Java] Combine MapVector and NonNullableMapVector Classes
> ---------------------------------------------------------
>
> Key: ARROW-1866
> URL: https://issues.apache.org/jira/browse/ARROW-1866
> Project: Apache Arrow
> Issue Type: Sub-task
> Components: Java - Vectors
> Reporter: Bryan Cutler
> Assignee: Bryan Cutler
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> {{NonNullableMapVector}} class can be merged into {{MapVector}} and removed
> as part of removing the non nullable vectors.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
